Skip to content

Allow specifying compileSdk #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

Users should be able to select compileSdk. Add --compileSdk option and
DO NOT verify it against our min required compile sdk.
This implements:
#927

Set min required compileSdk to 22 according to:
#920

@rosen-vladimirov rosen-vladimirov self-assigned this Sep 25, 2015
@rosen-vladimirov rosen-vladimirov added this to the 1.4.0 (Under review) milestone Sep 25, 2015
@ns-bot
Copy link

ns-bot commented Sep 25, 2015

Test PASSed.

@teobugslayer
Copy link
Contributor

Can you also add documentation in this PR?

Users should be able to select compileSdk. Add `--compileSdk` option and
DO NOT verify it against our min required compile sdk.
This implements:
#927

Set min required compileSdk to 22 according to:
#920
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/update-min-compile-sdk branch from 051c6af to 0985be6 Compare September 29, 2015 06:31
@rosen-vladimirov
Copy link
Contributor Author

@teobugslayer I've added required documentation :)

@ns-bot
Copy link

ns-bot commented Sep 29, 2015

Test PASSed.

@dtopuzov
Copy link
Contributor

👍

1 similar comment
@teobugslayer
Copy link
Contributor

👍

rosen-vladimirov added a commit that referenced this pull request Sep 29, 2015
@rosen-vladimirov rosen-vladimirov merged commit 9e67966 into master Sep 29, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/update-min-compile-sdk branch September 29, 2015 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants